INFOPLAT-3111: Fix atomic swapper for otel zap core#20019
Merged
Conversation
Contributor
|
👋 kirqz23, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
kirqz23
changed the title
product-security-plaid-production
bot
requested a review
from gustavogama-cll
jmank88
reviewed
Oct 23, 2025
kirqz23
added
build-publish
|
jmank88
approved these changes
Oct 23, 2025
pkcll
approved these changes
Oct 23, 2025
This was referenced Oct 22, 2025
This was referenced Nov 7, 2025
This was referenced Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AtomicCore.With()method was breaking the atomic chain when fields were applied to the logger, preventing swapping of otel core correctly. The main issue was thatd.load().With(fs)was returning totally new noop core disconnected from atomic core.The fix introduces a weak pointer solution that maintains atomic core connections while preventing memory leaks and tracks child cores created via
.With()calls.